fix(UI): remove commit_id in tree/blob table#1338
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the commit_id field from the git_tree and git_blob database tables and their associated model structs, along with implementing a new approach for tracking tree-commit relationships through commit history traversal.
- Removes
commit_idcolumn from database models and creates a migration to drop these columns - Updates the
get_tree_relate_commitmethod to use commit history traversal instead of direct database lookups - Refactors caching mechanism to use
Arc<Mutex<GitObjectCache>>for thread-safe access
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| mercury/src/internal/model/tree.rs | Removes commit_id field from Tree to git_tree::Model conversion |
| mercury/src/internal/model/blob.rs | Removes commit_id field from Blob to git_blob::Model conversion |
| jupiter/src/migration/mod.rs | Adds new migration module for removing commit_id columns |
| jupiter/src/migration/m20250815_075653_remove_commit_id.rs | Database migration to drop commit_id columns from git_blob and git_tree tables |
| jupiter/callisto/src/git_tree.rs | Removes commit_id field from git_tree Model struct |
| jupiter/callisto/src/git_blob.rs | Removes commit_id field from git_blob Model struct |
| ceres/src/api_service/mono_api_service.rs | Updates get_tree_relate_commit signature and implementation |
| ceres/src/api_service/mod.rs | Updates trait signature and implements thread-safe caching with Arc |
| ceres/src/api_service/import_api_service.rs | Implements new commit history traversal logic to replace database-based commit_id lookups |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
genedna
enabled auto-merge
August 18, 2025 02:40
genedna
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.